Skip to content

Subtitles and Collections #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sziep wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Subtitles and Collections #1

sziep wants to merge 6 commits into from

Conversation

@sziep
Copy link

@sziep sziep commented Mar 31, 2015

Hi,

I added the option to also put subtitles in the Title and If a recording has directory Information (usually for recurring schedules of the same show) it gets added to the collections.

@pgaubatz
Copy link
Owner

pgaubatz commented Apr 2, 2015

Hi,

thanks for your contribution!
I was just wondering if there is any reason why one would not want to include the subtitle?
If there is none, I'd suggest that we remove the corresponding preference/settings option again...

pgaubatz
pgaubatz reviewed Apr 2, 2015
View reviewed changes
Contents/Code/__init__.py
Copy link
Owner

@pgaubatz pgaubatz Apr 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is not needed anymore, right?

Copy link
Author

@sziep sziep Apr 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh no, that slipped through.

@sziep
Copy link
Author

sziep commented Apr 2, 2015

Actually, I don't mind making this a default. If you prefer to remove the option, go ahead. I have it enabled anyways. I just thought you had a reason to not include it in your version, so I made it optional. This would work for everybody :)

Also, this querying of upcoming recordings was not intended to be in the pull request yet. I wanted to clean it up first... githubbing is hard sometimes :P
This is also a feature which could cause problems for some users. Because I noticed that when playing a file which is currently recorded, the playback is without sound and stuttering. At least on my LG PLAYz Media app... So it might make sense to make this optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sziep @pgaubatz